Potential fix for code scanning alert no. 1: Use of a broken or weak cryptographic hashing algorithm on sensitive data #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cryptographic hashing algorithm on sensitive data Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ModusOperandom/skills-introduction-to-repository-management/security/code-scanning/1
To fix the issue, we need to replace the insecure
hashlib.sha256hashing function with a secure password hashing algorithm. The best approach is to use a library likeargon2-cffi, which implements the Argon2 password hashing algorithm. Argon2 is computationally expensive, includes built-in salting, and is specifically designed for password hashing.Steps to fix:
argon2-cffilibrary if it is not already installed.hash_passwordfunction to use Argon2 for hashing passwords.loginfunction to verify the password using Argon2'sverifymethod instead of directly comparing hashed values.Suggested fixes powered by Copilot Autofix. Review carefully before merging.